Unify transport settings naming #36623
Conversation
Tim-Brooks
added
>enhancement
:Distributed Coordination/Network
|
Pinging @elastic/es-distributed |
|
There is some inconsistency in our settings naming. Particularly as I think we want to move away from the This PR is kind of a POC to see if there is agreement that this is the direction we want to head. If it is, I can open a meta issue with the follow plan:
These are the settings I would like to delete and their replacement: D: D: D: D: D: D: D: D: D: D: |
|
run gradle build tests 2 |
|
Good change, thanks @tbrooks8. |
This commit updates our transport settings for 7.0. It generally takes a few approaches. First, for normal transport settings, it usestransport. instead of transport.tcp. Second, it uses transport.tcp, http.tcp, or network.tcp for all settings that are proxies for OS level socket settings. Third, it marks the network.tcp.connect_timeout setting for removal. Network service level settings are only settings that apply to both the http and transport modules. There is no connect timeout in http. Fourth, it moves all the transport settings to a single class TransportSettings similar to the HttpTransportSettings class. This commit does not actually remove any settings. It just adds the new renamed settings and adds todos for settings that will be deprecated.
This commit updates our transport settings for 7.0. It generally takes a few approaches. First, for normal transport settings, it usestransport. instead of transport.tcp. Second, it uses transport.tcp, http.tcp, or network.tcp for all settings that are proxies for OS level socket settings. Third, it marks the network.tcp.connect_timeout setting for removal. Network service level settings are only settings that apply to both the http and transport modules. There is no connect timeout in http. Fourth, it moves all the transport settings to a single class TransportSettings similar to the HttpTransportSettings class. This commit does not actually remove any settings. It just adds the new renamed settings and adds todos for settings that will be deprecated.
This commit updates our transport settings for 7.0. It generally takes a
few approaches. First, for normal transport settings, it uses
transport.instead of
transport.tcp. Second, it usestransport.tcp,http.tcp,or
network.tcpfor all settings that are proxies for OS level socketsettings. Third, it marks the
network.tcp.connect_timeoutsetting forremoval. Network service level settings are only settings that apply to
both the http and transport modules. There is no connect timeout in
http. Fourth, it moves all the transport settings to a single class
TransportSettingssimilar to theHttpTransportSettingsclass.This commit does not actually remove any settings. It just adds the new
renamed settings and adds todos for settings that will be deprecated.